Add PHP support - #199
Merged
langston-barrett merged 4 commits intoSep 23, 2025
Merged
Conversation
Owner
|
Thanks for the contribution @JuanCortezEclyp! Can you update the Let me know if you need help with this. |
langston-barrett
enabled auto-merge (squash)
September 23, 2025 21:43
Owner
|
Thank you! |
langston-barrett
disabled auto-merge
September 23, 2025 21:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Langston, this PR aims to add support for PHP.
Also I have a question don't know if you know the answer but one of the generated relations is named float, have you got any idea if this conflicts with souffles builtin type 'float'? I tested compiling the relations file or running it over an empty set of facts and souffle hasn't complained yet.
I could change how the relations names that match with souffle's builtin types are generated, in case something breaks.